Allow users to delete transform requests #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenGalewsky
force-pushed
the
859_archive_request
branch
from
dfe2dbb to
462ad1b
Compare
This is accomplished by adding a new boolean to the transform request table, archived. Setting archived to True removes the transform for reports and requests. When a transform is archived, the transform results table records are deleted and the contents of the bucket that held the transformed files are deleted, along with that bucket.
BenGalewsky
force-pushed
the
859_archive_request
branch
from
462ad1b to
1eb3193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in #859 - This PR allows users to request deleting a transform from the CLI.
This is accomplished by adding a new boolean to the transform request table, archived. Setting archived to True removes the transform for reports and requests.
When a transform is archived, the transform results table records are deleted and the contents of the bucket that held the transformed files are deleted, along with that bucket.
The action will report an error if you try to delete a transform that is still running