Skip to content

Minor spelling, syntax, type changes #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 12, 2023
Merged

Minor spelling, syntax, type changes #269

merged 10 commits into from
Jul 12, 2023

Conversation

@gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented Jul 11, 2023

  • Fix spelling
  • Fix some simple type checking errors
  • Add some things to test_hash

There should be no logic changes

@gordonwatts gordonwatts changed the base branch from master to servicex_client July 11, 2023 17:46
@gordonwatts gordonwatts requested a review from BenGalewsky July 11, 2023 17:46
@gordonwatts gordonwatts self-assigned this Jul 11, 2023
@gordonwatts gordonwatts added the enhancement New feature or request label Jul 11, 2023
BenGalewsky
BenGalewsky approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty hard to review with all of the black formatting changes folded in... taking your word for it...

@BenGalewsky BenGalewsky merged commit fd788f7 into servicex_client Jul 12, 2023
@BenGalewsky BenGalewsky deleted the servicex_client_caching branch July 12, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenGalewsky BenGalewsky BenGalewsky approved these changes

Assignees

@gordonwatts gordonwatts

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gordonwatts @BenGalewsky