Match the root file result format in the generated json to the expected value in the service #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed value in the service. For consistency sake, the enum was changed to root, however this is not what the server expects. To fix this we keep the enum key root, but make the string representation root-file. Added a unit test to verify this along with a pointer to the statement in the ServiceX client which sets up the valid values for this field
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## servicex_client #324 +/- ##
===================================================
+ Coverage 79.66% 79.70% +0.03%
===================================================
Files 33 33
Lines 1613 1616 +3
===================================================
+ Hits 1285 1288 +3
Misses 328 328
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The following setup breaks for me with this update:
from servicex.dataset_identifier import FileListDataset
from servicex.servicex_client import ServiceXClient
sx = ServiceXClient(backend="uproot")
dataset_id = FileListDataset("root://eospublic.cern.ch//eos/opendata/atlas/OutreachDatasets/2020-01-22/4lep/MC/mc_345060.ggH125_ZZ4lep.4lep.root")
ds = (sx
.func_adl_dataset(dataset_id, codegen="uproot", title="Root", result_format="root")
.set_tree("mini")
)
files_root = ds.Select(lambda e: {'lep_pt': e['lep_pt']}).Where(lambda e: e['lep_pt'] > 1000).as_files()via
pydantic.error_wrappers.ValidationError: 1 validation error for TransformRequest
result-format
value is not a valid enumeration member; permitted: 'parquet', 'root-file' (type=type_error.enum; enum_values=[<ResultFormat.parquet: 'parquet'>, <ResultFormat.root: 'root-file'>])result_format=ResultFormat.root works, as does result_format="root-file" (the older version?).
edit: I did not read the description properly, so the "root-file" string representation is expected. I believe it is quite convenient to be able to use the string representation, but confusing if that cannot also be "root".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency sake, the enum was changed to root, however this is not what the server expects. To fix this we keep the enum key root, but make the string representation root-file. Added a unit test to verify this along with a pointer to the statement in the ServiceX client which sets up the valid values for this field