Skip to content

Conversation

@prajwalkkumar
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b7dea4e) 79.66% compared to head (c038610) 81.19%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           servicex_client     #325      +/-   ##
===================================================
+ Coverage            79.66%   81.19%   +1.52%     
===================================================
  Files                   33       33              
  Lines                 1613     1696      +83     
===================================================
+ Hits                  1285     1377      +92     
+ Misses                 328      319       -9     
Flag Coverage Δ
unittests 81.19% <100.00%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
servicex/query_cache.py 98.38% <100.00%> (+14.78%) ⬆️
tests/test_dataset.py 100.00% <100.00%> (ø)
tests/test_query_cache.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prajwalkkumar prajwalkkumar changed the base branch from master to servicex_client October 9, 2023 19:42
@prajwalkkumar prajwalkkumar force-pushed the query_cache_tests branch 2 times, most recently from 6ccf4ca to b90940e Compare October 16, 2023 18:38
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fine new tests to catch weird network issues

@BenGalewsky BenGalewsky merged commit fa8adf7 into servicex_client Oct 16, 2023
@BenGalewsky BenGalewsky deleted the query_cache_tests branch October 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants