Skip to content

Conversation

@gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented Oct 22, 2023

  • New version of uproot/awkward returns the version number for tree keys - but can't handle them in an uproot.open. Strip off the version number if it is there.
    • Classic example of VMS living on!
  • Revise default configuration for backend name to reflect how ServiceX is usually configured, moving from atlasxaod to atlasr21.

Fixes #326

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c61bdad) 98.45% compared to head (ad02e78) 98.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          12       12           
  Lines        1166     1168    +2     
=======================================
+ Hits         1148     1150    +2     
  Misses         18       18           
Flag Coverage Δ
unittests-3.10 98.37% <100.00%> (+<0.01%) ⬆️
unittests-3.11 98.37% <100.00%> (+<0.01%) ⬆️
unittests-3.7 98.28% <100.00%> (+<0.01%) ⬆️
unittests-3.8 98.37% <100.00%> (+<0.01%) ⬆️
unittests-3.9 98.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
servicex/data_conversions.py 98.27% <100.00%> (+0.03%) ⬆️
servicex/servicex.py 100.00% <ø> (ø)
servicex/servicex_config.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonwatts gordonwatts added the bug Something isn't working label Oct 22, 2023
@gordonwatts gordonwatts changed the title Fix CI/CD tests Safeguard against VMS version numbers in tree names returned by uproot Oct 22, 2023
@gordonwatts gordonwatts merged commit e9cd5a6 into master Oct 22, 2023
@gordonwatts gordonwatts deleted the pr_new_versions branch October 22, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed CI/CD tests are failing on the master branch

2 participants