Skip to content

Conversation

@kyungeonchoi
Copy link
Contributor

  • First ServiceX DataBinder integration
  • Only for Python transformer for this PR

@kyungeonchoi kyungeonchoi added the enhancement New feature or request label Dec 5, 2023
@codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (fa8adf7) 81.19% compared to head (99ec526) 83.35%.
Report is 3 commits behind head on servicex_client.

Files Patch % Lines
servicex/databinder/databinder_configuration.py 88.42% 14 Missing ⚠️
servicex/databinder/databinder_deliver.py 54.83% 14 Missing ⚠️
servicex/databinder/databinder_outputs.py 69.69% 10 Missing ⚠️
servicex/databinder/databinder_requests.py 81.63% 9 Missing ⚠️
servicex/databinder/databinder.py 83.33% 2 Missing ⚠️
servicex/python_dataset.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           servicex_client     #333      +/-   ##
===================================================
+ Coverage            81.19%   83.35%   +2.16%     
===================================================
  Files                   33       40       +7     
  Lines                 1696     2295     +599     
===================================================
+ Hits                  1377     1913     +536     
- Misses                 319      382      +63     
Flag Coverage Δ
unittests 83.35% <83.81%> (+2.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change for the client!
I pointed out some commented-out code. We generally don't want that in the final PR, so please delete those lines if they aren't needed.

A couple of methods are very complicated and deserve comments explaining them.

I pushed a commit to the ssl-hep repo with a new test for the string-based python functions and also to correct the method type signature to match this new usage. I don't have write permission to your repo to add this commit to the PR myself. You should be able to cherry pick this commit

I pointed out that this code would be much simpler if the databinder config was a pydantic class instead of a raw dict. It's ok if you want to tackle that in a subsequent PR and not hold this up.

@BenGalewsky
Copy link
Contributor

I see that you have write permission to this repo. Instead of a fork, your could move your changes to a branch of this repo so I can also push commits to it.

@BenGalewsky BenGalewsky self-requested a review December 20, 2023 18:01
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - thanks for the cleanup

@BenGalewsky BenGalewsky merged commit 8716baf into ssl-hep:servicex_client Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants