-
Notifications
You must be signed in to change notification settings - Fork 13
First DataBinder integration #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First DataBinder integration #333
Conversation
kyungeonchoi
commented
Dec 5, 2023
- First ServiceX DataBinder integration
- Only for Python transformer for this PR
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## servicex_client #333 +/- ##
===================================================
+ Coverage 81.19% 83.35% +2.16%
===================================================
Files 33 40 +7
Lines 1696 2295 +599
===================================================
+ Hits 1377 1913 +536
- Misses 319 382 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change for the client!
I pointed out some commented-out code. We generally don't want that in the final PR, so please delete those lines if they aren't needed.
A couple of methods are very complicated and deserve comments explaining them.
I pushed a commit to the ssl-hep repo with a new test for the string-based python functions and also to correct the method type signature to match this new usage. I don't have write permission to your repo to add this commit to the PR myself. You should be able to cherry pick this commit
I pointed out that this code would be much simpler if the databinder config was a pydantic class instead of a raw dict. It's ok if you want to tackle that in a subsequent PR and not hold this up.
|
I see that you have write permission to this repo. Instead of a fork, your could move your changes to a branch of this repo so I can also push commits to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - thanks for the cleanup