Skip to content

Conversation

@gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented Jan 24, 2024

  • Added test that will try to open a file simple.root.1:treeme.

ToDo:

  • Make sure the ci.yaml is properly changed back.

Fixes #337

@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9cd5a6) 98.45% compared to head (b6f3858) 98.45%.

❗ Current head b6f3858 differs from pull request most recent head c2e5ea7. Consider uploading reports for the commit c2e5ea7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          12       12           
  Lines        1168     1168           
=======================================
  Hits         1150     1150           
  Misses         18       18           
Flag Coverage Δ
unittests-3.10 98.37% <100.00%> (ø)
unittests-3.11 98.37% <100.00%> (ø)
unittests-3.7 98.28% <0.00%> (ø)
unittests-3.8 98.37% <100.00%> (ø)
unittests-3.9 98.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The saftey is failing. I do not understand the reason. I modified the ci.yaml temporarily. Note that pip show pip shows 23.3.2 but saftey throws on 23.2.1. The only thing I can think is pip is in there twice, and the pip install --upgrade pip dosen't upgrade one of the original pip's.

Here are the commands I ran:

          python -m pip install safety
          python -m pip list
          python -m pip freeze
          python -m pip show pip
          python -m pip freeze | python -m safety check

And the output from the pip show:

Name: pip
Version: 23.3.2
Summary: The PyPA recommended tool for installing Python packages.
Home-page: https://pip.pypa.io/
Author: The pip developers
Author-email: [email protected]
License: MIT
Location: /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages
Requires: 
Required-by: 

And then the output of the saftey command:

+==============================================================================+

                               /$$$$$$            /$$
                              /$$__  $$          | $$
           /$$$$$$$  /$$$$$$ | $$  \__//$$$$$$  /$$$$$$   /$$   /$$
          /$$_____/ |____  $$| $$$$   /$$__  $$|_  $$_/  | $$  | $$
         |  $$$$$$   /$$$$$$$| $$_/  | $$$$$$$$  | $$    | $$  | $$
          \____  $$ /$$__  $$| $$    | $$_____/  | $$ /$$| $$  | $$
          /$$$$$$$/|  $$$$$$$| $$    |  $$$$$$$  |  $$$$/|  $$$$$$$
         |_______/  \_______/|__/     \_______/   \___/   \____  $$
                                                          /$$  | $$
                                                         |  $$$$$$/
  by safetycli.com                                        \______/

+==============================================================================+

 REPORT 

  Safety is using PyUp's free open-source vulnerability database. This
data is 30 days old and limited. 
  For real-time enhanced vulnerability data, fix recommendations, severity
reporting, cybersecurity support, team and project policy management and more
sign up at https://pyup.io or email [email protected]

  Safety v3.0.1 is scanning for Vulnerabilities...
  Scanning dependencies in your environment:

  -> /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages
  -> /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/lib-dynload
  -> /opt/hostedtoolcache/Python/3.11.7/x64/lib/python311.zip
  -> /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11
  -> /home/runner/work/ServiceX_frontend/ServiceX_frontend

  Using open-source vulnerability database
  Found and scanned 171 packages
  Timestamp 2024-01-24 09:12:01
  1 vulnerability reported
  0 vulnerabilities ignored

+==============================================================================+
 VULNERABILITIES REPORTED 
+==============================================================================+

-> Vulnerability found in pip version 23.2.1
   Vulnerability ID: 62044
   Affected spec: <23.3
   ADVISORY: Pip 23.3 includes a fix for CVE-2023-5752: When
   installing a package from a Mercurial VCS URL (ie "pip install hg+...")...
   CVE-2023-5752
   For more information about this vulnerability, visit
   https://data.safetycli.com/v/62044/97c
   To ignore this vulnerability, use PyUp vulnerability id 62044 in safety’s
   ignore command-line argument or add the ignore to your safety policy file.

In the end, I'm going to merge without this check passing. If I disable saftey then all test pass.

@gordonwatts gordonwatts merged commit 53fb813 into master Jan 24, 2024
@gordonwatts gordonwatts deleted the pr_uproot_trees branch January 24, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree Open Fails

2 participants