Skip to content

Conversation

@BenGalewsky
Copy link
Contributor

After extensive testing with the 3.0 api, users have suggested moving to a fully declarative api, based on DataBinder.

In this PR, we moved Databinder classes to pydantic

@codecov
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 53.52941% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 79.83%. Comparing base (46607ef) to head (fa83c18).

❗ Current head fa83c18 differs from pull request most recent head 4a203a2. Consider uploading reports for the commit 4a203a2 to get more accurate results

Files Patch % Lines
servicex/databinder_models.py 54.02% 40 Missing ⚠️
servicex/servicex_client.py 15.21% 39 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           servicex_client     #340      +/-   ##
===================================================
- Coverage            82.23%   79.83%   -2.40%     
===================================================
  Files                   40       41       +1     
  Lines                 2116     2247     +131     
===================================================
+ Hits                  1740     1794      +54     
- Misses                 376      453      +77     
Flag Coverage Δ
unittests 79.83% <53.52%> (-2.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenGalewsky BenGalewsky marked this pull request as ready for review March 15, 2024 14:18
@BenGalewsky BenGalewsky merged commit 53524e4 into servicex_client Mar 15, 2024
@BenGalewsky BenGalewsky deleted the databindereatstheworld branch March 15, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants