Skip to content

ci: Use trusted publishers for publishing to PyPI #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024
Merged

ci: Use trusted publishers for publishing to PyPI #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/pypi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
jobs:
publish:
runs-on: ubuntu-latest
# Mandatory for publishing with a trusted publisher
# c.f. https://docs.pypi.org/trusted-publishers/using-a-publisher/
permissions:
id-token: write
Comment on lines +10 to +13
Copy link
Member Author

@matthewfeickert matthewfeickert Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I have not added the strongly encouraged recommendation of adding a specific release environment (would be done under https://github.com/ssl-hep/ServiceX_frontend/settings/environments) as I wanted to run this past the dev team first. If this is of interest, I can add it in and explain any questions people have.


steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -59,7 +63,6 @@ jobs:
if: github.repository == 'ssl-hep/ServiceX_frontend'
uses: pypa/[email protected]
with:
password: ${{ secrets.pypi_password_servicex }}
print-hash: true

build-docs:
Expand Down