Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 2, 2024

$ git grep "nest_asyncio"  # Only used in databinder module
servicex/databinder/databinder_deliver.py:import nest_asyncio
servicex/databinder/databinder_deliver.py:nest_asyncio.apply()

Amends PR #349.

* As the databinder module is deprecated and scheduled for removal, remove
  nest-asyncio from the required core dependencies.
* Add a 'databinder' extra that includes the nest-asyncio dependency, as
  the databinder module still exists and should be kept functional until
  it is removed or revised.
@matthewfeickert
Copy link
Member Author

cc @kyungeonchoi, @BenGalewsky, @gordonwatts for review.

@codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (4b8403c) to head (99dc757).

Additional details and impacted files
@@             Coverage Diff              @@
##           3.0_develop     #356   +/-   ##
============================================
  Coverage        79.89%   79.89%           
============================================
  Files               41       41           
  Lines             2253     2253           
============================================
  Hits              1800     1800           
  Misses             453      453           
Flag Coverage Δ
unittests 79.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member Author

👋 Ping for review.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is nice.

@BenGalewsky BenGalewsky merged commit fd74676 into ssl-hep:3.0_develop Apr 12, 2024
@matthewfeickert
Copy link
Member Author

Thanks for the review and merge, Ben!

@matthewfeickert matthewfeickert deleted the build/remove-nest-asyncio branch April 13, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants