Process Transform Title and Log URL #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added CLI option "logs" to redirect user to transform ids error logs * removed the URL optional opening, added info and error level, removed the table * Added loglevel in models for info and error * Removed Log Level from models.py * Logic to add the filters in the URL, _a parameters for request id, log level and g parameters for time frame * edited the logs cli option to use the log url from transformation status message
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #366 +/- ##
===============================================
+ Coverage 72.28% 73.78% +1.50%
===============================================
Files 41 42 +1
Lines 2226 2300 +74
===============================================
+ Hits 1609 1697 +88
+ Misses 617 603 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The users would like to know the title of transforms and not just the request ID. They would also like to be able to view the logs for a transform without having to navigate the dashboard
Approach
REST server nows sends the title over as well as the basic Logs url. Client will now parse this and use it in various places