-
Notifications
You must be signed in to change notification settings - Fork 13
Use logging library for status updates #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #371 +/- ##
===============================================
+ Coverage 73.78% 74.97% +1.19%
===============================================
Files 42 42
Lines 2300 2406 +106
===============================================
+ Hits 1697 1804 +107
+ Misses 603 602 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a chance that some of these logging.info should be downgraded to logging.debug.
| return self | ||
|
|
||
| async def submit_and_download( | ||
| self, signed_urls_only: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting changes in the same commit as the code changes make the review a lot harder. If you want to change formatting, it's more polite to make that a single commit and then have the meat of the PR in a second commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make the logger class variables in these two classes? It seems messy to keep repeating the logging.get_logger("__name__")
This PR will exchange some of the
rich.printcalls that happen as the library runs and route them throughlogging.infoandlogging.warningandlogging.error.