Skip to content

Conversation

@gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented May 12, 2024

PR #378 was working but not tuned up before the submission. This PR:

  • Improves error logic (it wasn't wrong before, just two options for a branch)
  • Improves the error message further.

Error message now looks like the following:

  File "/venv/lib/python3.9/site-packages/servicex/dataset_group.py", line 76, in as_signed_urls_async
    return await asyncio.gather(*self.tasks)
  File "/venv/lib/python3.9/site-packages/servicex/query.py", line 521, in as_signed_urls_async
    return await self.submit_and_download(
  File "/venv/lib/python3.9/site-packages/servicex/query.py", line 260, in submit_and_download
    self.request_id = await self.servicex.submit_transform(sx_request)
  File "/venv/lib/python3.9/site-packages/servicex/servicex_adapter.py", line 120, in submit_transform
    raise RuntimeError("ServiceX WebAPI Error during transformation "
RuntimeError: ServiceX WebAPI Error during transformation submission: 504 - <Response [504 Gateway Time-out]>

@codecov
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (e015c93) to head (7191e4e).

Files Patch % Lines
servicex/servicex_adapter.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           3.0_develop     #379      +/-   ##
===============================================
- Coverage        73.88%   73.85%   -0.04%     
===============================================
  Files               42       42              
  Lines             2309     2310       +1     
===============================================
  Hits              1706     1706              
- Misses             603      604       +1     
Flag Coverage Δ
unittests 73.85% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gordonwatts gordonwatts self-assigned this May 12, 2024
@gordonwatts gordonwatts added the bug Something isn't working label May 12, 2024
@gordonwatts gordonwatts marked this pull request as ready for review May 12, 2024 17:09
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better

@BenGalewsky BenGalewsky merged commit cac86d6 into 3.0_develop May 12, 2024
@BenGalewsky BenGalewsky deleted the bug/clean_up_error branch May 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants