Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jun 21, 2024

Fix accidental lowercase in the enum definition

@ponyisi ponyisi changed the title 3.0_develop_pending Fix status code enum Jun 21, 2024
@codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (ec93d6a) to head (6ca3713).

Additional details and impacted files
@@             Coverage Diff              @@
##           3.0_develop     #399   +/-   ##
============================================
  Coverage        75.01%   75.01%           
============================================
  Files               30       30           
  Lines             1421     1421           
============================================
  Hits              1066     1066           
  Misses             355      355           
Flag Coverage Δ
unittests 75.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi ponyisi requested a review from kyungeonchoi June 21, 2024 21:48
@kyungeonchoi
Copy link
Contributor

@ponyisi - Does this need to be matched with the TransformStatus class in ServiceX?

@ponyisi
Copy link
Collaborator Author

ponyisi commented Jun 27, 2024

@ponyisi - Does this need to be matched with the TransformStatus class in ServiceX?

They need to at least map the same strings (which they do now, even if the names of the enum variables are slightly different).

@kyungeonchoi kyungeonchoi merged commit d4ac576 into 3.0_develop Jun 27, 2024
@kyungeonchoi kyungeonchoi deleted the 3.0_develop_pending branch June 27, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants