Skip to content

Conversation

@ketan96-m
Copy link
Collaborator

For transformers which have failed, the user can quickly go to the kibana link created from the terminal.
There are 3 steps:

  1. Transformer completes with some failure - display the kibana link with all the level ('INFO' and 'ERROR')
  2. Request cancelled - display the kibana link with all the level('INFO' and 'ERROR')
  3. Fatal issue - display the kibana link with level('ERROR')

Used the create_kibana_link_parameters method from transformers.py

To display all the levels, added an IF condition in the this method include or not include log level

@codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.92%. Comparing base (c99292b) to head (554b512).
Report is 10 commits behind head on 3.0_develop.

Additional details and impacted files
@@               Coverage Diff               @@
##           3.0_develop     #403      +/-   ##
===============================================
+ Coverage        75.01%   75.92%   +0.90%     
===============================================
  Files               30       30              
  Lines             1421     1491      +70     
===============================================
+ Hits              1066     1132      +66     
- Misses             355      359       +4     
Flag Coverage Δ
unittests 75.92% <100.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyungeonchoi kyungeonchoi self-requested a review June 27, 2024 16:25
Copy link
Contributor

@kyungeonchoi kyungeonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice improvement! It looks great!

Screenshot 2024-06-28 at 9 19 58 AM

@kyungeonchoi kyungeonchoi merged commit 86d9cd0 into 3.0_develop Jun 28, 2024
@kyungeonchoi kyungeonchoi deleted the failed_tranformer_url branch June 28, 2024 14:20
@ponyisi
Copy link
Collaborator

ponyisi commented Jun 28, 2024

Dumb question: will the link work on "dumb" terminals?

@kyungeonchoi
Copy link
Contributor

@ponyisi - it's a fair question. And the answer is no :(
There seems to a way to make a clickable link in terminals.

@ponyisi
Copy link
Collaborator

ponyisi commented Jun 30, 2024

So I guess the question is, whether to have a fallback for terminals?

@ketan96-m
Copy link
Collaborator Author

We can give the option to try the CLI option for each failed transform request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants