-
Notifications
You must be signed in to change notification settings - Fork 13
Logging Kibana URL for transformers with failures #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #403 +/- ##
===============================================
+ Coverage 75.01% 75.92% +0.90%
===============================================
Files 30 30
Lines 1421 1491 +70
===============================================
+ Hits 1066 1132 +66
- Misses 355 359 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyungeonchoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Dumb question: will the link work on "dumb" terminals? |
|
@ponyisi - it's a fair question. And the answer is no :( |
|
So I guess the question is, whether to have a fallback for terminals? |
|
We can give the option to try the CLI option for each failed transform request. |

For transformers which have failed, the user can quickly go to the kibana link created from the terminal.
There are 3 steps:
Used the
create_kibana_link_parametersmethod fromtransformers.pyTo display all the levels, added an IF condition in the this method include or not include log level