Fix Sample option NFiles for Dataset
#425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #425 +/- ##
===============================================
+ Coverage 80.59% 80.62% +0.02%
===============================================
Files 26 26
Lines 1340 1342 +2
===============================================
+ Hits 1080 1082 +2
Misses 260 260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenGalewsky
reviewed
Aug 21, 2024
servicex/databinder_models.py
Outdated
| def dataset_identifier(self) -> DataSetIdentifier: | ||
| if self.Dataset: | ||
| return self.Dataset | ||
| if isinstance(self.Dataset, RucioDatasetIdentifier): |
There was a problem hiding this comment.
isinstance is usually a code smell? Can this be done with inheritance?
There was a problem hiding this comment.
@BenGalewsky - Better now? :)
BenGalewsky
reviewed
Aug 22, 2024
| def dataset_identifier(self) -> DataSetIdentifier: | ||
| if self.Dataset: | ||
| if self.NFiles: | ||
| self.Dataset.num_files = self.NFiles |
There was a problem hiding this comment.
I cleaned up some redundant code. Looks good to me
BenGalewsky
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFilesis properly propagated forRucioDIDbut not for Rucio dataset defined viaDataset. e.g.Dataset: servicex.dataset.Rucio("mc20_13TeV:EXAMPLE_DID")