Skip to content

Conversation

@kyungeonchoi
Copy link
Contributor

  • Set timeout in the ExponentialRetry than client methods such as post

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@BenGalewsky
Copy link
Contributor

Oops, broken tests

@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.73%. Comparing base (ee80fdc) to head (53ec302).
Report is 2 commits behind head on 3.0_develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           3.0_develop     #438   +/-   ##
============================================
  Coverage        81.73%   81.73%           
============================================
  Files               26       26           
  Lines             1341     1341           
============================================
  Hits              1096     1096           
  Misses             245      245           
Flag Coverage Δ
unittests 81.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyungeonchoi
Copy link
Contributor Author

Oops, broken tests

Interesting - it passes local tests :) Let me have a look

@ponyisi
Copy link
Collaborator

ponyisi commented Sep 4, 2024

Oops, broken tests

Interesting - it passes local tests :) Let me have a look

This is some kind of cache db locking problem ...

@kyungeonchoi
Copy link
Contributor Author

Let me merge as it passes all tests

@kyungeonchoi kyungeonchoi merged commit daed1b1 into 3.0_develop Sep 4, 2024
@kyungeonchoi kyungeonchoi deleted the 3.0-update-timeouts branch September 4, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants