Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Sep 4, 2024

Address #295 by only verifying that we only list the S3 buckets when we have a cached record if we are trying to get local files when only signed URLs are cached, or vice versa. Fix a number of tests.

@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (daed1b1) to head (91e4573).
Report is 3 commits behind head on 3.0_develop.

Additional details and impacted files
@@               Coverage Diff               @@
##           3.0_develop     #439      +/-   ##
===============================================
+ Coverage        81.73%   82.71%   +0.98%     
===============================================
  Files               26       26              
  Lines             1341     1423      +82     
===============================================
+ Hits              1096     1177      +81     
- Misses             245      246       +1     
Flag Coverage Δ
unittests 82.71% <ø> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, glad this works!

@BenGalewsky BenGalewsky merged commit 1480824 into 3.0_develop Sep 5, 2024
@BenGalewsky BenGalewsky deleted the 3.0-network-disconnection branch September 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants