Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Sep 18, 2024

Sometimes listing the bucket for an in-progress transformation gives objects that look like directories, not files. These have no file size reported and would raise an exception due to the coercion in the ResultFile constructor. Avoid these problematic objects.

@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (2dfb069) to head (49cf33d).
Report is 1 commits behind head on 3.0_develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           3.0_develop     #458   +/-   ##
============================================
  Coverage        82.02%   82.02%           
============================================
  Files               26       26           
  Lines             1363     1363           
============================================
  Hits              1118     1118           
  Misses             245      245           
Flag Coverage Δ
unittests 82.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi ponyisi added this to the 3.0 Release milestone Sep 18, 2024
@gordonwatts gordonwatts added the bug Something isn't working label Sep 18, 2024
Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine with me. The only thing that comes to mind is if this gets combined with a "transform done" - so a file gets missed from the list of files reported to the client.

However, I know that is a more general problem and this fixes something specific. So lets approve this, and get it in, and then we'll address that bug when we actually see it.

@ponyisi
Copy link
Collaborator Author

ponyisi commented Sep 18, 2024

Yeah - in any case this is strictly better behavior than we had before, because we would have just crashed and lost everything. I'm not 100% what circumstances lead to this but we should in any case validate the full number of expected files in the bucket at the end of transforms.

@ponyisi ponyisi merged commit 408974a into 3.0_develop Sep 18, 2024
53 checks passed
@ponyisi ponyisi deleted the 3.0-minio-no-directories branch September 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants