Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Sep 18, 2024

When there are several in-flight transformations, a failure in one would cause all progress bars to be marked as red (until they completed). This is misleading; transforms that have not failed should still be green. This fix makes only the broken transforms show up as red.

@ponyisi ponyisi changed the base branch from master to 3.0_develop September 18, 2024 00:57
@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 82.06442% with 245 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (1b1c19c) to head (394b3fa).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
servicex/app/transforms.py 50.00% 51 Missing ⚠️
servicex/app/cache.py 0.00% 39 Missing ⚠️
servicex/func_adl/util.py 13.95% 37 Missing ⚠️
servicex/func_adl/func_adl_dataset.py 68.75% 30 Missing ⚠️
servicex/app/main.py 0.00% 20 Missing ⚠️
servicex/configuration.py 76.38% 17 Missing ⚠️
servicex/app/codegen.py 0.00% 16 Missing ⚠️
servicex/func_adl/func_adl_dataset_group.py 0.00% 16 Missing ⚠️
servicex/servicex_client.py 94.54% 9 Missing ⚠️
servicex/expandable_progress.py 91.66% 7 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   80.14%   82.06%   +1.91%     
==========================================
  Files          26       26              
  Lines        1355     1366      +11     
==========================================
+ Hits         1086     1121      +35     
+ Misses        269      245      -24     
Flag Coverage Δ
unittests 82.06% <82.06%> (+1.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi ponyisi added this to the 3.0.1 Bugfixes milestone Sep 18, 2024
Copy link
Collaborator

@ketan96-m ketan96-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring this, it makes it cleaner

@ponyisi ponyisi merged commit 55d44f0 into 3.0_develop Sep 18, 2024
@ponyisi ponyisi deleted the 3.0-fix-progressbar-color branch September 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants