-
Notifications
You must be signed in to change notification settings - Fork 13
Add retries on the get request of get_transform_status function
#469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #469 +/- ##
===============================================
+ Coverage 82.32% 83.40% +1.07%
===============================================
Files 26 26
Lines 1386 1440 +54
===============================================
+ Hits 1141 1201 +60
+ Misses 245 239 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is only one change that needs to happen now - the 10 second minimum for the backoff. I'm worried how long 5 failures will take if you have something like transform not found (which happens when you re-run things). Also, please create an issue for us to restrict the retry exceptions. The blanket means anything else goes wrong and the system will "hang" while it keep re-trying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. Please add an issue for follow up.
getrequest ofget_transform_statusfunction