Skip to content

Conversation

@kyungeonchoi
Copy link
Contributor

@kyungeonchoi kyungeonchoi added this to the 3.0 Release milestone Sep 19, 2024
@codecov
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (e681796) to head (5bc0c40).
Report is 27 commits behind head on 3.0_develop.

Additional details and impacted files
@@               Coverage Diff               @@
##           3.0_develop     #469      +/-   ##
===============================================
+ Coverage        82.32%   83.40%   +1.07%     
===============================================
  Files               26       26              
  Lines             1386     1440      +54     
===============================================
+ Hits              1141     1201      +60     
+ Misses             245      239       -6     
Flag Coverage Δ
unittests 83.40% <100.00%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is only one change that needs to happen now - the 10 second minimum for the backoff. I'm worried how long 5 failures will take if you have something like transform not found (which happens when you re-run things). Also, please create an issue for us to restrict the retry exceptions. The blanket means anything else goes wrong and the system will "hang" while it keep re-trying.

@kyungeonchoi kyungeonchoi marked this pull request as ready for review September 23, 2024 18:48
Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Please add an issue for follow up.

@kyungeonchoi kyungeonchoi merged commit 0a4d740 into 3.0_develop Sep 23, 2024
36 checks passed
@kyungeonchoi kyungeonchoi deleted the fix-ClientPayloadError branch September 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants