Skip to content

Add retries for s3 interactions with tenacity #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add retries for s3 interactions with tenacity #479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef1f34
Add retries for s3 interactions with tenacity
ponyisi Sep 25, 2024
9408053
Fix bad source file
ponyisi Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions servicex/minio_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from hashlib import sha1
from pathlib import Path
from typing import List
from tenacity import retry, stop_after_attempt, wait_random_exponential

from miniopy_async import Minio

Expand Down Expand Up @@ -69,6 +70,8 @@ def for_transform(cls, transform: TransformStatus):
bucket=transform.request_id,
)

@retry(stop=stop_after_attempt(3), wait=wait_random_exponential(max=60),
reraise=True)
async def list_bucket(self) -> List[ResultFile]:
objects = await self.minio.list_objects(self.bucket)
return [
Expand All @@ -80,6 +83,8 @@ async def list_bucket(self) -> List[ResultFile]:
for obj in objects if not obj.is_dir
]

@retry(stop=stop_after_attempt(3), wait=wait_random_exponential(max=60),
reraise=True)
async def download_file(
self, object_name: str, local_dir: str, shorten_filename: bool = False
) -> Path:
Expand All @@ -98,6 +103,8 @@ async def download_file(
)
return path.resolve()

@retry(stop=stop_after_attempt(3), wait=wait_random_exponential(max=60),
reraise=True)
async def get_signed_url(self, object_name: str) -> str:
return await self.minio.get_presigned_url(
bucket_name=self.bucket, object_name=object_name, method="GET"
Expand Down