Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Sep 27, 2024

Add a class to encapsulate an XRootD dataset request (resolve #477)

@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (0487232) to head (c124d55).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   82.89%   82.97%   +0.08%     
==========================================
  Files          26       26              
  Lines        1397     1404       +7     
==========================================
+ Hits         1158     1165       +7     
  Misses        239      239              
Flag Coverage Δ
unittests 82.97% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. But might need better eyes, @ponyisi

@ponyisi ponyisi merged commit 730e61f into master Oct 2, 2024
36 checks passed
@ponyisi ponyisi deleted the 477_xrootd_class branch October 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add XRootD dataset lookup as a first-class dataset object

3 participants