-
Notifications
You must be signed in to change notification settings - Fork 13
Cache Collision when the user ignores the cache and hash is present in the db Fix #375 #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 82.89% 83.52% +0.63%
==========================================
Files 26 26
Lines 1397 1451 +54
==========================================
+ Hits 1158 1212 +54
Misses 239 239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Could you add a test for the specific code path that codecov is complaining about? Then I'll approve |
|
@ponyisi @gordonwatts ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok - thanks for fixing this annoying bug
Problem
Resolve #375
When the user submits a transform without
ignore-cache-> records are inserted as expectedWhen the user submits same transform with
ignore-cache-> a NEW record is still created (tiny db has no unique value contraints)When the user submits same tranform without
ignore-cache-> 2 records are present hence raises exceptionFix
When the user submits a query and selects ignore_cache -
Check if we have a previous hash already present and if present delete that record since we are going to run the transform again.