Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 3, 2024

Resolve #449 by exposing DeliveryEnum as servicex.Delivery (OutputFormat was already added). Add documentation.

@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.22%. Comparing base (f6799a9) to head (7cf5cf0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   83.21%   83.22%   +0.01%     
==========================================
  Files          26       26              
  Lines        1424     1425       +1     
==========================================
+ Hits         1185     1186       +1     
  Misses        239      239              
Flag Coverage Δ
unittests 83.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi ponyisi requested a review from kyungeonchoi October 3, 2024 13:56
Copy link
Contributor

@kyungeonchoi kyungeonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@kyungeonchoi kyungeonchoi merged commit 18c9431 into master Oct 15, 2024
36 checks passed
@kyungeonchoi kyungeonchoi deleted the 449_exports_2 branch October 15, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OutputFormatEnum and DeliveryEnum are not exposed to the library user

3 participants