Skip to content

Conversation

@ketan96-m
Copy link
Collaborator

Resolves #499

Added a validation step that raises an exception if duplicate samples are submitted.
Used the dataset, query and codegen to create the hash of the sample.

@ketan96-m ketan96-m requested a review from ponyisi October 28, 2024 19:49
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (959c3af) to head (f7b1932).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   83.64%   83.90%   +0.26%     
==========================================
  Files          26       26              
  Lines        1461     1485      +24     
==========================================
+ Hits         1222     1246      +24     
  Misses        239      239              
Flag Coverage Δ
unittests 83.90% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ketan96-m ketan96-m requested a review from ponyisi November 1, 2024 18:21
@ponyisi ponyisi merged commit 226d3dc into master Nov 1, 2024
39 checks passed
@ponyisi ponyisi deleted the validate_multi_samples branch November 1, 2024 19:14
@ponyisi
Copy link
Collaborator

ponyisi commented Nov 1, 2024

Thanks for all the work, @ketan96-m !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check duplicate sample in a ServiceXSpec

3 participants