Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion servicex/servicex_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ async def get_dataset(self, dataset_id=None) -> CachedDataset:
dataset = CachedDataset(**result)
return dataset

async def delete_dataset(self, dataset_id=None):
async def delete_dataset(self, dataset_id=None) -> bool:
headers = await self._get_authorization()
path_template = '/servicex/datasets/{dataset_id}'
url = self.url + path_template.format(dataset_id=dataset_id)
Expand All @@ -189,6 +189,8 @@ async def delete_dataset(self, dataset_id=None):
elif r.status != 200:
msg = await _extract_message(r)
raise RuntimeError(f"Failed to delete dataset {dataset_id} - {msg}")
result = await r.json()
return result['stale']

async def submit_transform(self, transform_request: TransformRequest) -> str:
headers = await self._get_authorization()
Expand Down
3 changes: 2 additions & 1 deletion tests/test_servicex_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,12 @@ async def test_delete_dataset(delete, servicex):
}
delete.return_value.__aenter__.return_value.status = 200

await servicex.delete_dataset(123)
r = await servicex.delete_dataset(123)
delete.assert_called_with(
url='https://servicex.org/servicex/datasets/123',
headers={}
)
assert r


@pytest.mark.asyncio
Expand Down
Loading