build: Restrict ruamel-yaml to v0.18.6 or older #542
Conversation
| "aiofile", # compatible versions controlled through miniopy-async | ||
| "make-it-sync", # compatible versions controlled through func_adl | ||
| "ruamel.yaml>=0.18", | ||
| "ruamel.yaml>=0.18,<0.18.7", # FIXME: ruamel-yaml v0.18.7 has a breaking API change relative to v0.18.6 |
There was a problem hiding this comment.
I'm selecting a temporary upper bound here instead of using the disallow syntax
"ruamel.yaml>=0.18,!=0.18.7,!=0.18.8,!=0.18.9,!=0.18.10
as the maintainer is on a release streak (maybe a bad sign after a year of nothing) and it is clear that there's an API breaking change that is going to have to get resolved, so a this is known to fail and it isn't going to get better with an upstream fix, we should cap for now.
matthewfeickert
changed the title
matthewfeickert
force-pushed
the
ci/fix-environment
branch
from
be62614 to
e687ffd
Compare
|
@BenGalewsky @gordonwatts @ponyisi this is ready for review. |
matthewfeickert
changed the title
matthewfeickert
force-pushed
the
ci/fix-environment
branch
from
e687ffd to
6146431
Compare
|
(Sorry the force pushes are because I apparently can't spell in my commit messages. 😞 ) |
* ruamel-yaml v0.18.7 has a breaking API change relative to v0.18.6. Until this can be fixed, introduce a short lived version cap. - c.f. https://pypi.org/project/ruamel.yaml/0.18.7/ c.f. https://sourceforge.net/p/ruamel-yaml/code/ci/0.18.7/tree/
matthewfeickert
force-pushed
the
ci/fix-environment
branch
from
6146431 to
2f9594a
Compare
|
Actually, the maintainer does seem to be actively responding to tickets on SourceForge: https://sourceforge.net/p/ruamel-yaml/tickets/ So if someone on the ServiceX team wanted to make a SourceForge account you might be able to get some information from them. |
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
Ah yes - thank you @matthewfeickert
|
This should hopefully be viewed as a short lived temporary fix until Issue #543 can be addressed. |
2 participants
Resolves #540