Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jan 17, 2025

Add black
Run pre-commit run --all-files

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 97.41935% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (604d83f) to head (c5f045c).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
servicex/app/datasets.py 60.00% 2 Missing ⚠️
servicex/app/transforms.py 80.00% 1 Missing ⚠️
servicex/func_adl/func_adl_dataset.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   92.27%   92.26%   -0.02%     
==========================================
  Files          27       27              
  Lines        1748     1745       -3     
==========================================
- Hits         1613     1610       -3     
  Misses        135      135              
Flag Coverage Δ
unittests 92.26% <97.41%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - let's get this in before anyone has merge conflicts

@ponyisi ponyisi merged commit 66d78fe into master Jan 17, 2025
36 checks passed
@ponyisi ponyisi deleted the pre-commit branch January 17, 2025 22:00
@matthewfeickert
Copy link
Member

matthewfeickert commented Jan 17, 2025

If style formatting PRs like this (which I love — huzzah for smaller diffs in the future) are ever annoying for git blame in the future you can add a .git-blame-ignore-revs to the top level of the repository with a list of commit hashes to ignore. GitHub will automatically pick this up for you when you use the web interface, but you can run this locally too with

git blame --ignore-revs-file .git-blame-ignore-revs

c.f. matplotlib/matplotlib#22809 for an exmaple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants