Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jan 20, 2025

Make it clearer what is going on in test

The endpoint will be printed in the test. As it is a secret, to get it to output it is encoded via xxd -ps; it can be de-encoded by xxd -r -ps.

@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (a3c989a) to head (fbb044d).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          29       29           
  Lines        1823     1823           
=======================================
  Hits         1688     1688           
  Misses        135      135           
Flag Coverage Δ
unittests 92.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ponyisi ponyisi temporarily deployed to production-service January 20, 2025 16:40 — with GitHub Actions Inactive
@ponyisi ponyisi temporarily deployed to production-service January 20, 2025 16:47 — with GitHub Actions Inactive
@ponyisi ponyisi had a problem deploying to production-service January 20, 2025 17:17 — with GitHub Actions Failure
@ponyisi ponyisi temporarily deployed to production-service January 20, 2025 17:25 — with GitHub Actions Inactive
@BenGalewsky BenGalewsky self-requested a review January 21, 2025 21:27
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice one

@BenGalewsky BenGalewsky merged commit b669a11 into master Jan 21, 2025
38 checks passed
@BenGalewsky BenGalewsky deleted the ponyisi-patch-1 branch January 21, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants