Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jan 21, 2025

Remove some code that is not hit by any Query code path

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (0f6e6a6) to head (7358381).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   92.59%   95.94%   +3.34%     
==========================================
  Files          29       28       -1     
  Lines        1823     1750      -73     
==========================================
- Hits         1688     1679       -9     
+ Misses        135       71      -64     
Flag Coverage Δ
unittests 95.94% <100.00%> (+3.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was never brave enough to change any of this code. Thank you for your service!

@BenGalewsky BenGalewsky merged commit 3ece5f3 into master Jan 21, 2025
37 checks passed
@BenGalewsky BenGalewsky deleted the func-adl-test-coverage branch January 21, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants