Use uv to set up python version in tests #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponyisi
changed the title
matthewfeickert
approved these changes
Mar 25, 2025
Comment on lines
+47
to
+48
| uv pip install --upgrade '.[test,docs]' | ||
| uv pip list |
There was a problem hiding this comment.
Ah that's interesting. I didn't realize that if you setup Python with uv that it knows how to automatically activate the default virtual environment it creates.
That's good to know, so thanks @ponyisi!
There was a problem hiding this comment.
Ah, @ponyisi do you want to also apply these changes to all the other GitHub Action workflows?
ServiceX_frontend/.github/workflows/ci_production.yaml
Lines 30 to 36 in 8288202
ServiceX_frontend/.github/workflows/docs.yml
Lines 32 to 38 in 8288202
ServiceX_frontend/.github/workflows/pypi.yaml
Lines 25 to 31 in 8288202
?
kyungeonchoi
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Add free-thread Python 3.13 and preview Python 3.14 to test matrix * Setup python with uv? * No system uv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a conflict in setting up Python versions with 3.13t if we use both the setup-python and setup-uv actions. Do only the latter. (This PR does not itself bring in 3.13t, that has conflicts with dependencies, specifically aiohttp aio-libs/aiohttp#10467 .)