Skip to content

Avoid trying to interpret cached transformations in the SUBMITTED state #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025
Merged

Avoid trying to interpret cached transformations in the SUBMITTED state #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion servicex/query_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ def cached_queries(self) -> List[TransformedResults]:
with self.lock:
result = [
TransformedResults(**doc)
for doc in self.db.search(transforms.request_id.exists())
for doc in self.db.search(
transforms.request_id.exists() & ~(transforms.status == "SUBMITTED")
)
]
return result

Expand Down
3 changes: 3 additions & 0 deletions tests/test_query_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,9 @@ def test_get_transform_request_id(transform_request, completed_status):
request_id = cache.get_transform_request_id(hash_value)
assert request_id == "123456"

# assert that in this state that cached_queries does NOT crash and returns nothing
assert len(cache.cached_queries()) == 0

cache.close()


Expand Down
Loading