Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jul 13, 2025

Codegen caching on the client side is not saving very much network activity but potentially causes users to be surprised that backend installations apparently don't support transformations that they should. In any case we obtain this data on every session because we request the capabilities, so we can actually eliminate the caching with zero added cost to the backend.

@codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (188c034) to head (43a0666).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   96.50%   96.49%   -0.01%     
==========================================
  Files          29       29              
  Lines        1974     1942      -32     
==========================================
- Hits         1905     1874      -31     
+ Misses         69       68       -1     
Flag Coverage Δ
unittests 96.49% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder about keeping that backend parameter in the servicex client method, but otherwise this is a better approach. Thanks

@ponyisi ponyisi force-pushed the no-cache-codegens branch from e3c6ceb to 43a0666 Compare July 13, 2025 21:42
@ponyisi ponyisi merged commit 196629e into master Jul 13, 2025
37 checks passed
@ponyisi ponyisi deleted the no-cache-codegens branch July 13, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants