Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jul 21, 2025

httpx has much shorter timeouts than aiohttp did, and large submissions can exceed the default 5s limits. Raise this for submissions to be much closer to aiohttpx.

@BenGalewsky BenGalewsky self-requested a review July 21, 2025 18:13
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ponyisi ponyisi merged commit 00b43be into master Jul 21, 2025
35 checks passed
@ponyisi ponyisi deleted the submit-timeout branch July 21, 2025 18:39
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (2540895) to head (64ebd2c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   96.96%   96.97%           
=======================================
  Files          29       29           
  Lines        1947     1948    +1     
=======================================
+ Hits         1888     1889    +1     
  Misses         59       59           
Flag Coverage Δ
unittests 96.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants