Skip to content

Conversation

@gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented Sep 24, 2025

Summary

  • add an optional name filter argument to servicex datasets list that supports * wildcards and substring matching by default (use standard linux filename match rules from fnmatch python package)
  • filter cached dataset results in the CLI before rendering the table
  • cover the new behavior with CLI tests for both direct and wildcard patterns

https://chatgpt.com/codex/tasks/task_e_68cff0324a948320a0b6327245bb5e24

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (5be92bc) to head (df506ce).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   97.19%   97.20%   +0.01%     
==========================================
  Files          29       29              
  Lines        1961     1969       +8     
==========================================
+ Hits         1906     1914       +8     
  Misses         55       55              
Flag Coverage Δ
unittests 97.20% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gordonwatts gordonwatts self-assigned this Sep 24, 2025
@gordonwatts gordonwatts added the enhancement New feature or request label Sep 24, 2025
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks useful

@BenGalewsky BenGalewsky merged commit 62b479f into master Sep 24, 2025
37 checks passed
@BenGalewsky BenGalewsky deleted the codex/add-optional-argument-for-dataset-listing branch September 24, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants