Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 16, 2025

#654 added result printout functionality directly into the deliver() function, which will change the behavior quite significantly for people using the API directly. Refactor this code to CLI responsibility.

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.15%. Comparing base (c4edadc) to head (6b17ca4).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   98.15%   98.15%   -0.01%     
==========================================
  Files          29       29              
  Lines        2061     2060       -1     
==========================================
- Hits         2023     2022       -1     
  Misses         38       38              
Flag Coverage Δ
unittests 98.15% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some possible suggestions for a future PR

@ponyisi ponyisi merged commit e981849 into master Oct 23, 2025
37 checks passed
@ponyisi ponyisi deleted the app-deliver-verbosity branch October 23, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants