This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Support jobs #205
Merged
Support jobs #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soenkeliebau
approved these changes
Jun 23, 2021
Member
soenkeliebau
left a comment
soenkeliebau
left a comment
There was a problem hiding this comment.
LGTM
Ran integration tests and manually created a pod that runs a Kafka command with correct and incorrect parameters to check correct RC handling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pods with restart policy
Neverare handled correctly.Closes #117.
Integration tests are created in stackabletech/agent-integration-tests#37.
Review Checklist