Skip to content

Set version label in Superset image #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2022
Merged

Set version label in Superset image #108

merged 1 commit into from
May 3, 2022

Conversation

@siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented May 3, 2022

Set version label in Superset image

The version label was empty due to a missing ARG instruction in the Dockerfile.

@siegfriedweber siegfriedweber requested a review from maltesander May 3, 2022 08:44
@siegfriedweber siegfriedweber self-assigned this May 3, 2022
maltesander
maltesander approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@siegfriedweber siegfriedweber merged commit 8557143 into main May 3, 2022
@siegfriedweber siegfriedweber deleted the set_version_label_in_superset_image branch May 3, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siegfriedweber @maltesander