Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented May 17, 2024

Description

Part of #674.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. The changelog entry is missing. This

# ===
# Mitigation for CVE-2021-44228 (Log4Shell)
# This variable is supported as of Log4j version 2.10 and
# disables the vulnerable feature
ENV LOG4J_FORMAT_MSG_NO_LOOKUPS=true

should go into the main container.
We added the bin folder in other products to the path, could be done here as well for consistency?

@nightkr nightkr requested review from lfrancke and maltesander June 7, 2024 13:06
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one last thing

# ===
# Mitigation for CVE-2021-44228 (Log4Shell)
# This variable is supported as of Log4j version 2.10 and
# disables the vulnerable feature
ENV LOG4J_FORMAT_MSG_NO_LOOKUPS=true

should be in the final image.

@nightkr
Copy link
Contributor Author

nightkr commented Jun 12, 2024

Aah, good catch.

@nightkr nightkr requested a review from maltesander June 12, 2024 08:53
maltesander
maltesander previously approved these changes Jun 12, 2024
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nightkr nightkr added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 5d7d6f3 Jun 17, 2024
@nightkr nightkr deleted the feature/source/trino branch June 17, 2024 11:32
NickLarsenNZ added a commit that referenced this pull request Jan 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2025
…985)

revert(script): jmx exporter source upload back to jar upload

Reverts a single file from #687 which should have been done in #933.

[Slack discussion](https://stackable-workspace.slack.com/archives/C02FZ581UCD/p1738149918664689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants