Skip to content

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 14, 2025

Description

Part of stackabletech/issues#747
This PR adds Prometheus annotations and adds a pod port for metrics

kafka_target_health

BREAKING:

The <cluster>-<role>-<rolegroup> service was replaced with a <cluster>-<role>-<rolegroup>-headless and <cluster>-<role>-<rolegroup>-metrics service.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Oct 14, 2025
@maltesander maltesander added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Oct 14, 2025
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Oct 14, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

One comment seems to be unnecessary

razvan
razvan previously approved these changes Oct 14, 2025
@maltesander maltesander added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 6cfd7aa Oct 14, 2025
17 checks passed
@maltesander maltesander deleted the chore/ensure-metrics-correctly-exposed branch October 14, 2025 10:56
@maltesander maltesander moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants