fix: cannot find image reference when copying remote server #1037
+136
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where copying remote servers to a group would fail because the API call was incorrectly including an image field for remote servers. The fix conditionally structures the request payload based on whether the server is remote (uses url) or local (uses image).
Key Changes
- Conditional payload structure in
useCopyServerToGrouphook to handle remote vs local servers differently - Added test coverage for the remote server copy scenario to ensure the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
renderer/src/features/mcp-servers/hooks/use-copy-server-to-group.ts |
Restructured the createWorkload payload to conditionally include either remote server fields (url, oauth_config) or local server fields (image, volumes, cmd_arguments) |
renderer/src/features/mcp-servers/hooks/__tests__/use-copy-server-to-group.test.tsx |
Added comprehensive test to verify that remote servers are copied with the correct payload structure |
peppescg
reviewed
Oct 13, 2025
renderer/src/features/mcp-servers/hooks/use-copy-server-to-group.ts
Outdated
Show resolved
Hide resolved
…nces-groups-feature-maybe
peppescg
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the bug that was mentioned here: https://stacklok.slack.com/archives/C091GRYAG49/p1760022742218379?thread_ts=1760003349.102839&cid=C091GRYAG49