Skip to content

Conversation

@kantord
Copy link
Member

@kantord kantord commented Oct 13, 2025

Notes about testing et cetera:

  • You will need a custom registry, because the default registry will not have groups
  • An example of a custom registry was included in the repo to simplify this
  • This is behind a feature flag. use FeatureFlag.groups_in_registry.enable()
  • This is NOT part of the groups feature and the first groups release
screenshot-2025-10-14_16-49-58

What's included:

  • All required logic to display groups on the registry page. Installing them is not yet possible, hence the need for the feature flag

How it looks when the feature flag is enabled AND using a custom registry with groups included:

recording-2025-10-14_16-50-56.mp4

when the feature flag is disabled, the groups are simply hidden. (Screenshot showing the same custom registry)

screenshot-2025-10-14_16-59-09

@kantord kantord changed the title Install groups from registry feat: list groups in registry Oct 13, 2025
@kantord kantord self-assigned this Oct 14, 2025
@kantord kantord marked this pull request as ready for review October 14, 2025 15:00
@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 15:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying groups in the registry page, implementing the foundational UI components for the groups feature. The functionality is controlled by a new feature flag GROUPS_IN_REGISTRY and includes comprehensive test coverage for the new functionality.

Key changes:

  • Adds groups display functionality to the registry page with feature flag control
  • Refactors registry card components to support both servers and groups through a unified interface
  • Implements comprehensive test coverage for groups display and empty state handling

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
utils/feature-flags.ts Adds new GROUPS_IN_REGISTRY feature flag key
renderer/src/routes/(registry)/registry.tsx Updates registry component to fetch and display groups when feature flag is enabled
renderer/src/features/registry-servers/types.ts Defines discriminated union type for registry items (servers and groups)
renderer/src/features/registry-servers/components/grid-cards-registry.tsx Refactors grid component to handle both servers and groups with unified filtering
renderer/src/features/registry-servers/components/card-registry.tsx Creates polymorphic card component that renders appropriate card type based on item type
renderer/src/features/registry-servers/components/card-registry-server.tsx Refactors server card to use shared base component
renderer/src/features/registry-servers/components/card-registry-group.tsx Implements new group card component with server count display
renderer/src/features/registry-servers/components/card-registry-base.tsx Extracts shared card layout and behavior into reusable base component
renderer/src/common/types/utils.ts Adds utility type for creating discriminated unions
renderer/src/routes/tests/registry.test.tsx Adds comprehensive test coverage for groups functionality
renderer/src/common/mocks/customHandlers/fixtures/default_registry.ts Updates mock data to include groups for testing
main/src/feature-flags.ts Registers new feature flag in main process
examples/registries/registry-with-groups.json Provides example registry configuration with groups

@kantord kantord merged commit ce6c305 into main Oct 15, 2025
13 checks passed
@kantord kantord deleted the install-groups-from-registry branch October 15, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants