-
Notifications
You must be signed in to change notification settings - Fork 8
fix: http server not ready when app start #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements better error handling and user experience for the bootstrap server startup process by introducing specialized error handling and loading states for ToolHive server health checks.
- Replaces generic error handling with specific
HealthCheckErrorclass and conditional error display logic - Introduces
StartingToolHivecomponent to show loading state during server initialization - Refactors error components to use a new
GenericErrorcomponent with better messaging
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| renderer/src/routes/__root.tsx | Adds HealthCheckError class and specialized error handling logic for server startup scenarios |
| renderer/src/common/components/starting-toolhive.tsx | New loading component that polls health endpoint and navigates on success |
| renderer/src/common/components/error/index.tsx | Refactored to use GenericError component and updated error detection logic |
| renderer/src/common/components/error/generic-error.tsx | New generic error component extracted from previous inline implementation |
| renderer/src/common/components/error/tests/index.test.tsx | Updated tests to handle new error component structure and dependencies |
| renderer/src/common/components/tests/starting-toolhive.test.tsx | Comprehensive test suite for the new StartingToolHive component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn’t able to replicate the slowness, but overall, on both Windows and macOS, I didn’t notice any issues restarting or using the app
Loading toolhive experience, waiting for http server

Generic error after health check rety failed

Full flow
Kapture.2025-10-13.at.16.31.30.mp4