Skip to content

Conversation

@peppescg
Copy link
Collaborator

Loading toolhive experience, waiting for http server
Screenshot 2025-10-13 at 19 41 35

Generic error after health check rety failed
Screenshot 2025-10-13 at 17 31 50

Full flow

Kapture.2025-10-13.at.16.31.30.mp4

@peppescg peppescg self-assigned this Oct 13, 2025
@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 17:56
@peppescg peppescg changed the title Fix bootstrap server issue fix: bootstrap server issue Oct 13, 2025
@peppescg peppescg changed the title fix: bootstrap server issue fix: http server not ready when app start Oct 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements better error handling and user experience for the bootstrap server startup process by introducing specialized error handling and loading states for ToolHive server health checks.

  • Replaces generic error handling with specific HealthCheckError class and conditional error display logic
  • Introduces StartingToolHive component to show loading state during server initialization
  • Refactors error components to use a new GenericError component with better messaging

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
renderer/src/routes/__root.tsx Adds HealthCheckError class and specialized error handling logic for server startup scenarios
renderer/src/common/components/starting-toolhive.tsx New loading component that polls health endpoint and navigates on success
renderer/src/common/components/error/index.tsx Refactored to use GenericError component and updated error detection logic
renderer/src/common/components/error/generic-error.tsx New generic error component extracted from previous inline implementation
renderer/src/common/components/error/tests/index.test.tsx Updated tests to handle new error component structure and dependencies
renderer/src/common/components/tests/starting-toolhive.test.tsx Comprehensive test suite for the new StartingToolHive component

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@samuv samuv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn’t able to replicate the slowness, but overall, on both Windows and macOS, I didn’t notice any issues restarting or using the app

@peppescg peppescg merged commit d904abb into main Oct 14, 2025
20 checks passed
@peppescg peppescg deleted the fix-bootstrap-server-issue branch October 14, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants