Skip to content

Conversation

@peppescg
Copy link
Collaborator

Avoid connection refused loop in case of mismatch container engine check, showing generic error page, when the user can quit the app easily or restart the app with try again button

Kapture.2025-10-14.at.18.10.09.mp4

@peppescg peppescg self-assigned this Oct 14, 2025
Copilot AI review requested due to automatic review settings October 14, 2025 16:11
@peppescg peppescg linked an issue Oct 14, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a container engine loop issue by restructuring error handling to prevent connection refused loops when there's a mismatch with container engine availability. The changes move the containerEngineAvailable property from being directly on the Error object to being nested within the cause property, following standard Error object patterns.

  • Restructured error object to use proper cause property for container engine status
  • Updated error detection logic to check nested cause.containerEngineAvailable
  • Added restart functionality to error screen reload handler

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
renderer/src/routes/__root.tsx Updated error handling to use proper error typing with cause property
renderer/src/common/components/error/index.tsx Modified error detection to check containerEngineAvailable in cause object
renderer/src/common/components/error/base-error-screen.tsx Added restart call before window reload in error handler
renderer/src/common/components/error/tests/index.test.tsx Updated tests to use proper Error constructor with cause parameter

cursor[bot]

This comment was marked as outdated.

@peppescg peppescg merged commit 219a49d into main Oct 15, 2025
22 checks passed
@peppescg peppescg deleted the fix-container-engine-loop branch October 15, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Stuck in a restart loop because no runtime is available

3 participants