Skip to content

Conversation

yrobla
Copy link
Contributor

@yrobla yrobla commented Oct 10, 2025

Server was crashing with 404 errors when writing to telemetry

Closes: #2114

@yrobla yrobla requested review from JAORMX and blkt October 10, 2025 08:05
@yrobla yrobla force-pushed the issue-2114-telemetry branch 2 times, most recently from d7214b8 to a23c79f Compare October 10, 2025 08:16
@yrobla yrobla requested review from JAORMX and danbarr October 10, 2025 08:16
@yrobla
Copy link
Contributor Author

yrobla commented Oct 10, 2025

@danbarr i came with the cleanest approach. The error happens in the same lines (write header) but i added some error controls there to avoid that telemetry crashes the server. I think it's cleaner. Please try

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.83%. Comparing base (81e6666) to head (9e05fc7).

Files with missing lines Patch % Lines
pkg/telemetry/middleware.go 40.90% 10 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2147      +/-   ##
==========================================
- Coverage   48.84%   48.83%   -0.01%     
==========================================
  Files         242      242              
  Lines       30722    30741      +19     
==========================================
+ Hits        15005    15013       +8     
- Misses      14595    14603       +8     
- Partials     1122     1125       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yrobla yrobla force-pushed the issue-2114-telemetry branch from a23c79f to d78c0a4 Compare October 10, 2025 08:55
Server was crashing with 404 errors when writing to telemetry.
So add some control of panic error on the calls to telemetry, to
tolerate failures but don't make them fatal.
Also implement the flush method, that is essential for sse/streaming

Closes: #2114
@yrobla yrobla force-pushed the issue-2114-telemetry branch from d78c0a4 to 9e05fc7 Compare October 10, 2025 14:08
@danbarr
Copy link
Collaborator

danbarr commented Oct 10, 2025

@danbarr i came with the cleanest approach. The error happens in the same lines (write header) but i added some error controls there to avoid that telemetry crashes the server. I think it's cleaner. Please try

@yrobla I just tested with this new branch, and the fix is working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP session not found errors breaking Playwright MCP

5 participants