-
Notifications
You must be signed in to change notification settings - Fork 712
Setup for Clarity 4 and implement contract-hash?
#6403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See clarity-lang/reference#88 and stacks-network#6320 for dicsussion about this new builtin function.
For now, this is only accessible via the CLI: ```sh stacks-inspect contract-hash <path-to-contract> ```
Also adds Epoch 3.3 and costs-4 to support this new function and removes the MAST implementation from the previous proposal.
This is not needed since it will actually execute a read-only call in the Clarity version for the called contract. Removing this allows us to safely set `ClarityVersion::latest()` to return `Clarity4`.
Fix issues with different Clarity versions and add some more fake results from the test DBs.
These failing integration tests all pass locally. I don't recall seeing these be flaky in other PRs. I will take a look to see if I introduced a new source of flakiness somewhere. |
I believe the flakiness I saw before is solved by #6420. |
Merge conflicts resolved and ready for re-review. |
Setup for Clarity 4 and implement `contract-hash?`
Added |
f183be7
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (63.61%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6403 +/- ##
============================================
- Coverage 74.81% 63.61% -11.20%
============================================
Files 557 558 +1
Lines 341830 342708 +878
============================================
- Hits 255724 218013 -37711
- Misses 86106 124695 +38589
... and 299 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This is the first step in the Clarity 4 proposal (see SIP PR #218). This changes adds Epoch 3.3, Clarity version 4, and costs-4, which is needed for the new builtins. Epoch 3.3 is currently set to activate at Bitcoin height 33,000,000, and Clarity 4 does not activate until 3.3, so it should be safe to merge into develop.
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repo