fix(LM): Change default temperature and max_tokens to be None #8908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspy/clients/lm.py
Outdated
|
|
||
| if model_pattern: | ||
| if max_tokens < 16000 or temperature != 1.0: | ||
| if temperature == 0 and max_tokens == 4000: |
There was a problem hiding this comment.
Per our offline discussion, let's proceed with temperature=None and max_tokens=None as the default, which aligns with litellm defaults.
isaacbmiller
changed the title
isaacbmiller
force-pushed
the
isaac/gpt-5-warning
branch
from
14b76f0 to
3be87ac
Compare
Co-authored-by: Chen Qian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow users to just write dspy.LM("gpt-5-nano") but also there is the case where this overrides a user's settings.
I can see an argument against this change, but it seems the direction we are heading is that API users have less explicit control over the temperature.