Skip to content

Conversation

@dean-starkware
Copy link
Contributor

No description provided.

@dean-starkware dean-starkware requested a review from orizi June 22, 2025 12:10
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion


corelib/src/test/language_features/macro_test.cairo line 393 at r1 (raw file):

}

macro define_and_use unhygenic {

at the very least - but in any case - we should find another name.

Suggestion:

unhygienic

Copy link
Contributor Author

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/test/language_features/macro_test.cairo line 393 at r1 (raw file):

Previously, orizi wrote…

at the very least - but in any case - we should find another name.

yes, already took care of it, was a typo.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 12 files at r2.
Reviewable status: 6 of 12 files reviewed, 1 unresolved discussion


corelib/src/test/language_features/macro_test.cairo line 403 at r2 (raw file):

    define_and_use!();
    let _y = foo;
}

add another test that a hygienic macro calls a unhygienic macro.

Code quote:

macro define_and_use unhygienic {
    () => {
        let foo = 123;
    };
}

#[test]
fn test_define_and_use_unhygienic() {
    define_and_use!();
    let _y = foo;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants