Skip to content

Conversation

@odupontt
Copy link
Contributor

@odupontt odupontt commented Nov 15, 2025

  • Fix incorrect article usage: "an struct/handle/negative" → "a struct/handle/negative"
  • Fix typo in comment: "Assert that err_data bye the statement that was removed above." → " Assert err_data is produced by the statement that was removed above."

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion


crates/cairo-lang-lowering/src/panic/mod.rs line 142 at r1 (raw file):

            panic!("Expected a tuple construct before the panic.");
        };
        // Assert `err_data` by the statement that was removed above.

Suggestion:

        // Assert `err_data` is produced by the statement that was removed above.

@odupontt
Copy link
Contributor Author

@orizi Hi,
Thanks for the suggestion! I’ve updated the comment

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @odupontt)

@orizi orizi enabled auto-merge November 17, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants